Dawid Kowal - Etap 4, React Basics#112
Closed
GTR1701 wants to merge 1 commit into
Closed
Conversation
Konzum59
reviewed
Jun 25, 2025
Konzum59
left a comment
Konzum59
left a comment
Member
There was a problem hiding this comment.
Bardzo fajne zwięzłe i kluczowe testy. Jak dla mnie bardzo spoko, zwłaszcza biorąc pod uwagę brak wolnego czasu przez koniec semestru. Super cool
| it("shows empty state when no project matches", () => { | ||
| render(<SolvroProjectsCombobox />); | ||
| fireEvent.click(screen.getByRole("combobox")); | ||
| fireEvent.change(screen.getByPlaceholderText("Wyszukaj projekt..."), { |
Member
There was a problem hiding this comment.
generalnie wszystko jest super, jedyne co to chyba warto jest użyć getByPlaceholderText(/Wyszukaj/i) albo coś tego typu. Ale no ja nie jestem jakimś ekspertem, wydaje mi się po prostu delikatnie lepsze.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.