Skip to content

Comment column#191

Merged
jomey merged 3 commits into
release-0.6.xfrom
comment_column
Jun 18, 2025
Merged

Comment column#191
jomey merged 3 commits into
release-0.6.xfrom
comment_column

Conversation

@jomey

@jomey jomey commented Jun 12, 2025

Copy link
Copy Markdown
Member

Address GH-188

jomey added 2 commits June 12, 2025 10:04
Dropping the column in favor of making it a measurement_type, where the
value holds the information.

GH-188
Adding a text `comments` column to hold the information that is on the
top right of every pit sheet.

GH-188
@codecov

codecov Bot commented Jun 12, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.95%. Comparing base (fbf8976) to head (1fa28e7).
Report is 1 commits behind head on release-0.6.x.

Additional details and impacted files
@@              Coverage Diff               @@
##           release-0.6.x     #191   +/-   ##
==============================================
  Coverage          75.95%   75.95%           
==============================================
  Files                 21       21           
  Lines                653      653           
==============================================
  Hits                 496      496           
  Misses               157      157           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aaarendt aaarendt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test suite all green, this looks good!

Both are representing the same information, the top right comments box.
Using the 'comments' to be more descriptive (as I have personally
forgotten that we had it on the table already)
@jomey jomey merged commit e2a90e5 into release-0.6.x Jun 18, 2025
7 checks passed
@jomey jomey deleted the comment_column branch June 18, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants