x11: X11Surface bbox/geometry should match committed buffer#2030
Open
kelnos wants to merge 1 commit intoSmithay:masterfrom
Open
x11: X11Surface bbox/geometry should match committed buffer#2030kelnos wants to merge 1 commit intoSmithay:masterfrom
kelnos wants to merge 1 commit intoSmithay:masterfrom
Conversation
This was referenced May 10, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2030 +/- ##
==========================================
- Coverage 18.73% 18.44% -0.29%
==========================================
Files 182 183 +1
Lines 28934 29207 +273
==========================================
- Hits 5421 5388 -33
- Misses 23513 23819 +306
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
X11Surface::bbox() returns the geometry stored internally by X11Surface, which is based on the last committed configure attempted by the compositor (via configure()). The problem here is that the client is free to reject that size (size increments, min size, max size, etc.). In these cases, we can mis-render the window (placement or size) if the last configured rect is not the same as the actual committed buffer. Instead, use the surface/buffer size, and only fall back to X11Surface's geometry if that's not available.
kelnos
force-pushed
the
xwm-bbox-match-buffer
branch
from
587f573 to
a50b57c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
X11Surface::bbox()returns the geometry stored internally byX11Surface, which is based on the last committed configure attempted by the compositor (viaconfigure()). The problem here is that the client is free to reject that size (size increments, min size, max size, etc.).In these cases, we can mis-render the window (placement or size) if the last configured rect is not the same as the actual committed buffer.
Instead, use the surface/buffer size, and only fall back to
X11Surface's geometry if that's not available.(This used to be a part of #2018 but I decided to split it off since it's not strictly related.)
Checklist