dnd: Send only events supported by client#2028
Open
mati865 wants to merge 1 commit intoSmithay:masterfrom
Open
dnd: Send only events supported by client#2028mati865 wants to merge 1 commit intoSmithay:masterfrom
mati865 wants to merge 1 commit intoSmithay:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hi!
This PR addresses #2026 (shout out to bczhc for providing so much relevant info).
I have reproduced the issue in Anvil by DnD a file into GLFW window, and with these changes the crash is gone.
This feels out of place however, looking at the other protocols, some of them have nice abstractions with such check baked into:
smithay/src/wayland/selection/data_device/source.rs
Line 137 in 060e9cd
Perhaps I should add simple abstraction that checks the version similarly?
Checklist