drm/surface: Make sure we also reset pending#2021
Open
Drakulix wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is possible to end up in the very unfortunate situation of just setting the
pendingstate of aDrmSurfacebefore a call toDrmDevice::pause.This seems like a good thing, because after
activate, we presumably will transition to the new pending state without loosing any user operation. However a suspend/resume cycle might render theMode-blob created and set in the pending state invalid... Theoretically a connector could also disappear (with MST).Since most compositor will re-evaluate the current state and then apply their output configuration anew after a suspend/resume cycle anyway, I argue we should simply reset
pendingto the current state as well.Description
Checklist