Open
Conversation
34c75fb to
5d6e9d7
Compare
Member
|
Works as expected on my integrated AMD Radeon cards 👌 |
|
Works as expected in Niri with very minor changes to it on AMD :) Thank you for the good work |
|
Using #1946 + #1949 on NVIDIA Turing (with the Worth noting that DRM debugger reports the following message: |
|
I've been waiting for this for so long... 🥹 |
5d6e9d7 to
80c793c
Compare
Co-Authored-By: Christian Meissl <meissl.christian@gmail.com>
80c793c to
f8a8f0f
Compare
Collaborator
Author
Hm, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is based on #1335, but takes a slightly different route.
Instead of calculating the
PresentationModeinsideDrmCompositor::render_frameit expects to receivethe desired mode.
This should allow the following things:
the implicit handling might not have enough information about user-preference and calculating it
per frame could result in flip-flip between sync and async page flip which should be avoided imo
this should increase the chance that we can fulfill the async request
Note: This won't work as is on some intel hardware, because not all formats support async page flips.
I will try to come up with a solution, but that can wait for another day.
There is also a new environment variable in anvil to test this, running with
ANVIL_FORCE_TEARING=1shouldenable it.
@PolyMeilex I opened a separate PR because I did not like to overwrite your wonderful work, but I kept you
as the main author. I hope you don't mind.
Checklist