Skip to content

Fix ExprHash internal error when MD5 is used #8609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dev-Xeiji wants to merge 4 commits into
base: dev/patch
Choose a base branch
from
+3 −1
Open

Fix ExprHash internal error when MD5 is used #8609

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0366dd3
Fix ExprHash internal error when MD5 is used
Dev-Xeiji May 1, 2026
0b16f06
ParserInstance active check before calling getCurrentScript()
Dev-Xeiji May 1, 2026
afd03a6
Merge branch 'dev/patch' into patch-1
Dev-Xeiji May 1, 2026
90aa06e
Optimize parser calls by saving the result of getParser()
Dev-Xeiji May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/java/ch/njol/skript/expressions/ExprHash.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import java.util.Locale;

import ch.njol.skript.doc.*;
import ch.njol.skript.lang.parser.ParserInstance;
import org.bukkit.event.Event;
import org.jetbrains.annotations.Nullable;

Expand Down Expand Up @@ -51,7 +52,8 @@ public boolean init(Expression<?>[] exprs, int matchedPattern, Kleenean isDelaye
String algorithm = parseResult.tags.get(0).toUpperCase(Locale.ENGLISH);
try {
digest = MessageDigest.getInstance(algorithm);
if (algorithm.equals("MD5") && !getParser().getCurrentScript().suppressesWarning(ScriptWarning.DEPRECATED_SYNTAX)) {
ParserInstance parser = getParser();
if (algorithm.equals("MD5") && parser.isActive() && !parser.getCurrentScript().suppressesWarning(ScriptWarning.DEPRECATED_SYNTAX)) {
Skript.warning("MD5 is not secure and shouldn't be used if a cryptographically secure hashing algorithm is required.");
}
return true;
Expand Down