fix(mcp): implement signalToPromise dispose to remove abort listener#4
Closed
Skn0tt wants to merge 249 commits into
Closed
fix(mcp): implement signalToPromise dispose to remove abort listener#4Skn0tt wants to merge 249 commits into
Skn0tt wants to merge 249 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: microsoft-playwright-automation[bot] <203992400+microsoft-playwright-automation[bot]@users.noreply.github.com> Co-authored-by: Dmitry Gozman <dgozman@gmail.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…41082) whether it be from a dedicated protocol `timestamp` or the more general `timing` , we should use a value from the engine for `startDateTime` instead of the playwright server `Date`
… `response._transferSize` for `WebSocket` (microsoft#41091)
signalToPromise returned a no-op dispose, so the 'abort' listener it registered on the AbortSignal was never removed. The single caller in the test MCP context also discarded dispose entirely. Implement dispose to remove the listener and call it in a finally around the test run race.
✅ Deploy Preview for pw-docs-skn0tt ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Owner
Author
|
Superseded by microsoft#41160 (targeting upstream). |
Test results for "MCP"2 failed 7261 passed, 1109 skipped Merge workflow run. |
Test results for "tests 1"1 flaky39544 passed, 771 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
signalToPromisereturned a no-opdispose, leaking the'abort'listener it adds to theAbortSignal.disposeto remove the listener (with an earlysignal.abortedfast path).dispose()in afinallyat the single caller in the test MCP context so the listener is cleaned up on every exit path.