Skip to content

Updated AWSSDK.S3 to 4.0 #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mdupras wants to merge 2 commits into from
Closed

Updated AWSSDK.S3 to 4.0 #385

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0daca97
Updated AWSSDK to 4.0
mdupras Jun 4, 2025
7df450e
This is to Match v3 behavior
mdupras Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/ImageSharp.Web.Providers.AWS/AmazonS3ClientFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ namespace SixLabors.ImageSharp.Web;

internal static class AmazonS3ClientFactory
{
static AmazonS3ClientFactory() => AWSConfigs.InitializeCollections = true;
Copy link
Copy Markdown
Member

@JimBobSquarePants JimBobSquarePants Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Altering global behavior for transitive dependency does not appear be a prudent. It would be more appropriate to update the code to accommodate changes in behavior.


/// <summary>
/// Creates a new bucket under the specified account if a bucket
/// with the same name does not already exist.
Expand Down
Loading