Separate glyph/paint transforms; SVG caching & tests#524
Merged
JimBobSquarePants merged 5 commits intomainfrom Apr 9, 2026
Merged
Separate glyph/paint transforms; SVG caching & tests#524JimBobSquarePants merged 5 commits intomainfrom
JimBobSquarePants merged 5 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #524 +/- ##
=====================================
- Coverage 82% 82% -1%
=====================================
Files 305 305
Lines 21540 21618 +78
Branches 3167 3196 +29
=====================================
+ Hits 17822 17875 +53
- Misses 2903 2932 +29
+ Partials 815 811 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This pull request refactors how affine transforms are handled when flattening COLR v1 paint graphs, introducing a distinction between transforms applied to glyph geometry and those applied to paint nodes. It also updates the
ResolvedGlyphLayerstructure to store both transform types, and makes related adjustments in the rendering pipeline. Additionally, it improves caching and default paint handling in the SVG glyph source.COLR v1 Paint Graph Flattening and Transform Handling
FlattenPaintToLayersmethod to maintain two separate affine transforms:glyphTransform(applied to glyph geometry) andpaintTransform(applied to the leaf paint node), instead of a single accumulated transform. The method now takes both transforms as parameters and updates them appropriately depending on the paint node type. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]ResolvedGlyphLayerstructure to store bothGlyphTransformandPaintTransform, and adjusted its constructor and documentation accordingly. [1] [2] [3]GlyphTransformfor geometry transformation when constructingPaintedLayerinstances, ensuring that solid paints are transformed correctly.SVG Glyph Source Improvements
(int Start, int Length)) for improved cache accuracy and concurrency, and replaced the dictionary type withConcurrentDictionary. [1] [2]DefaultBlackFillPaint) to be used as the inherited paint when walking SVG elements, ensuring consistent fallback rendering. [1] [2]