Skip to content

Implement Hebrew and Thai/Lao Font Shapers#509

Merged
JimBobSquarePants merged 3 commits intomainfrom
js/optimize-fix
Mar 12, 2026
Merged

Implement Hebrew and Thai/Lao Font Shapers#509
JimBobSquarePants merged 3 commits intomainfrom
js/optimize-fix

Conversation

@JimBobSquarePants
Copy link
Copy Markdown
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Introduces dedicated shapers for Hebrew, Thai and Lao scripts.

In addition, multiple algorithmic optimizations were introduced to improve shaping performance.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 12, 2026

Codecov Report

❌ Patch coverage is 40.40115% with 208 lines in your changes missing coverage. Please review.
✅ Project coverage is 82%. Comparing base (ee58d0d) to head (07a5484).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...s/Tables/AdvancedTypographic/Shapers/ThaiShaper.cs 21% 123 Missing and 2 partials ⚠️
...Tables/AdvancedTypographic/Shapers/HebrewShaper.cs 16% 79 Missing and 3 partials ⚠️
...bors.Fonts/Tables/AdvancedTypographic/GPosTable.cs 0% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main    #509    +/-   ##
======================================
- Coverage     83%     82%    -1%     
======================================
  Files        303     305     +2     
  Lines      21208   21520   +312     
  Branches    3106    3161    +55     
======================================
+ Hits       17691   17797   +106     
- Misses      2715    2916   +201     
- Partials     802     807     +5     
Flag Coverage Δ
unittests 82% <40%> (-1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JimBobSquarePants JimBobSquarePants merged commit 48b8ab1 into main Mar 12, 2026
27 of 29 checks passed
@JimBobSquarePants JimBobSquarePants deleted the js/optimize-fix branch March 12, 2026 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant