Remove vertical ascent compensation and update test references#505
Merged
JimBobSquarePants merged 2 commits intomainfrom Mar 4, 2026
Merged
Remove vertical ascent compensation and update test references#505JimBobSquarePants merged 2 commits intomainfrom
JimBobSquarePants merged 2 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #505 +/- ##
=====================================
Coverage 83% 83%
=====================================
Files 274 274
Lines 19184 19171 -13
Branches 2719 2717 -2
=====================================
- Hits 16081 16071 -10
+ Misses 2426 2424 -2
+ Partials 677 676 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request refines the vertical glyph layout logic in
TextLayout.csby removing first-line ascent compensation for vertical and vertical-mixed text flows. This change prevents unwanted extra spacing before the first glyph, ensuring more visually consistent vertical text rendering. Additionally, several reference images for composed character vertical rendering tests have been updated to reflect the improved layout.Vertical layout logic improvements:
LayoutLineVerticalandLayoutLineVerticalMixed, restricting baseline adjustment to X-origin block alignment only. This prevents unnecessary leading space above the first glyph in vertical text columns. [1] [2]Test reference updates: