Skip to content

Upload CDN types diff as workflow artifact #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewiggins merged 1 commit into from
Apr 3, 2026
Merged

Upload CDN types diff as workflow artifact #560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/check-cdn-types.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,14 @@ jobs:
id: check
run: node packages/app-bridge-types/scripts/check-cdn-updates.mjs

- name: Upload diff artifact
if: steps.check.outputs.has_changes == 'true'
uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0
with:
name: cdn-types-diff
path: ${{ steps.check.outputs.diff_file }}
retention-days: 30

- name: Create PR
if: steps.check.outputs.has_changes == 'true'
env:
Expand Down
6 changes: 6 additions & 0 deletions packages/app-bridge-types/scripts/check-cdn-updates.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,8 +179,14 @@ Merging this PR will trigger a patch release of \`@shopify/app-bridge-types\`.
const prBodyFile = join(tempDir, 'pr-body.md');
writeFileSync(prBodyFile, prBody);

// Write diff to a file for artifact upload
const diffFile = join(tempDir, 'cdn-types.diff');
writeFileSync(diffFile, diff);

setOutput('has_changes', 'true');
setOutput('pr_body_file', prBodyFile);
setOutput('diff_file', diffFile);

console.log(`Diff written to ${diffFile}`);
console.log(`PR body written to ${prBodyFile}`);
console.log('Done.');