Skip to content

Accept both yml and yaml file extensions #1481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cardy31 merged 2 commits into from
Apr 2, 2026
Merged

Accept both yml and yaml file extensions #1481

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
897a160
Accept both yml and yaml file extensions
cardy31 Apr 2, 2026
db607e6
Remove a comma
cardy31 Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions app/models/shipit/deploy_spec/file_system.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,24 +106,30 @@ def load_config
build_config(config_file_path, config_obj)
end

YAML_EXTENSIONS = ["yml", "yaml"].freeze

def shipit_file_names_in_priority_order
[
"#{app_name}.#{@env}.yml",
".shipit/#{app_name}.#{@env}.yml",
YAML_EXTENSIONS.flat_map do |ext|
[
"#{app_name}.#{@env}.#{ext}",
".shipit/#{app_name}.#{@env}.#{ext}",

"#{app_name}.yml",
".shipit/#{app_name}.yml",
"#{app_name}.#{ext}",
".shipit/#{app_name}.#{ext}",

"shipit.#{@env}.yml",
".shipit/#{@env}.yml",
"shipit.#{@env}.#{ext}",
".shipit/#{@env}.#{ext}",

"shipit.yml",
".shipit/shipit.yml"
].uniq
"shipit.#{ext}",
".shipit/shipit.#{ext}"
]
end.uniq
end

def bare_shipit_filenames
["#{app_name}.yml", "shipit.yml", ".shipit/#{app_name}.yml", ".shipit/shipit.yml"].uniq
YAML_EXTENSIONS.flat_map do |ext|
["#{app_name}.#{ext}", "shipit.#{ext}", ".shipit/#{app_name}.#{ext}", ".shipit/shipit.#{ext}"]
end.uniq
end

def config_file_path
Expand Down
Loading