Skip to content

🏷️ types: move to ty #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SigureMo merged 2 commits into from
Apr 25, 2026
Merged

🏷️ types: move to ty #33

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11b06b3
Switch from pyright to ty
Copilot Apr 25, 2026
39715bf
Remove Pylance recommendation
Copilot Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .vscode/extensions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"recommendations": [
"ms-python.python",
"astral-sh.ty",
"ms-python.vscode-pylance",
Copy link
Copy Markdown
Contributor

@SigureMo SigureMo Apr 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot 删 pylance

Copy link
Copy Markdown
Contributor Author

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已移除，见 39715bf。

"charliermarsh.ruff",
"esbenp.prettier-vscode",
Comment on lines 3 to 6
Copy link

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.vscode/settings.json still contains Pylance-specific analysis/inlay-hint settings, and the PR description mentions keeping VS Code recommendations aligned with those settings, but this change removes the ms-python.vscode-pylance extension recommendation. Consider re-adding Pylance to the recommendations list (alongside astral-sh.ty), or remove the Pylance-specific settings if Pylance is no longer intended to be used.

Copilot uses AI. Check for mistakes.
Expand Down
1 change: 0 additions & 1 deletion .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"python.defaultInterpreterPath": "${workspaceFolder}/.venv/bin/python",
"python.analysis.typeCheckingMode": "strict",
"python.analysis.inlayHints.functionReturnTypes": true,
"python.analysis.inlayHints.variableTypes": true,
"[python]": {
Expand Down
2 changes: 1 addition & 1 deletion justfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ fmt:
uv run ruff format .

lint:
uv run pyright src/docufix tests
uv run ty check --error-on-warning src/docufix tests
uv run ruff check .

fmt-docs:
Expand Down
9 changes: 1 addition & 8 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,17 +32,12 @@ docufix = "docufix.__main__:main"

[dependency-groups]
dev = [
"pyright>=1.1.406",
"ty>=0.0.32",
"ruff>=0.14.0",
"pytest>=8.4.2",
"pytest-rerunfailures>=16.0.1",
]

[tool.pyright]
include = ["src/moelib", "tests"]
pythonVersion = "3.10"
typeCheckingMode = "strict"

[tool.ruff]
line-length = 120
target-version = "py310"
Expand All @@ -65,8 +60,6 @@ select = [
]
ignore = [
"E501", # line too long, duplicate with ruff fmt
"F401", # imported but unused, duplicate with pyright
"F841", # local variable is assigned to but never used, duplicate with pyright
"UP015", # it not met the "Explicit is better than implicit" rule
]

Expand Down
4 changes: 2 additions & 2 deletions src/docufix/utils/colorful.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
from __future__ import annotations

from typing import Final, TypeAlias
from typing import TypeAlias

Color: TypeAlias = Final[str]
Color: TypeAlias = str

CSI: Color = "\x1b["

Expand Down
50 changes: 26 additions & 24 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading