Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently we don't have a way to detect if a device is attached to a fast charger or external cooling. To ensure safe operation until we can do that I'd prefer to limit this to the safe DC with native cooling max TDP for now.
TBS, this chip has a much higher TDP in some desktop like applications we don't want to throttle. This value should instead be set to the silicon max TDP per AMD, then device specific overrides should populate from the vendor database to keep the known handhelds under safe levels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hence: model_name = "AMD RYZEN AI MAX+ 395 w/ Radeon 8060S"
in order to not break the devices for usual users: max_tdp should be equal 55w or 80w, 90 could overheat the device
as soon as the TDP becomes avialable in SteamOS QAM, it would be possible to change TDP manually above, say, 55w?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.