Skip to content

Governor upgrade simulation tests - #6

Merged
apbendi merged 2 commits into
mainfrom
governor-integration
Jul 10, 2026
Merged

apbendi merged 2 commits into
mainfrom
governor-integration

Conversation

@apbendi

@apbendi apbendi commented Jul 3, 2026

Copy link
Copy Markdown
Member

No description provided.

@apbendi
apbendi force-pushed the governor-integration branch from a007952 to c3270b2 Compare July 6, 2026 17:53
@apbendi
apbendi requested a review from alexkeating July 6, 2026 17:53
@apbendi
apbendi marked this pull request as ready for review July 6, 2026 17:54
@apbendi
apbendi force-pushed the governor-integration branch 2 times, most recently from 29123ee to e766af9 Compare July 6, 2026 18:10
Comment thread .github/workflows/ci.yml Outdated
Comment thread test/helpers/ProposeGovernorUpgradeTestConfig.sol
Comment thread test/GovernorUpgradeProposal.integration.t.sol Outdated
Comment thread test/PostUpgradeGovernance.integration.t.sol Outdated
@apbendi
apbendi force-pushed the gov-upgrade-proposal-script branch from d28d8e8 to 83af1e8 Compare July 10, 2026 18:58
@apbendi
apbendi force-pushed the governor-integration branch from e766af9 to c22db87 Compare July 10, 2026 20:08
@apbendi
apbendi changed the base branch from gov-upgrade-proposal-script to main July 10, 2026 20:08
* Add test for proposalNeedsQueueing override
* Turn coverage back to 100%
* Clarify test assumption vs assertion
@apbendi
apbendi force-pushed the governor-integration branch from c22db87 to a45a587 Compare July 10, 2026 20:26
@github-actions

Copy link
Copy Markdown

Coverage after merging governor-integration into main will be

100.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   GitcoinGovernorWithGuardian.sol100%100%100%100%
src/extensions
   GovernorSettableFixedQuorum.sol100%100%100%100%
   GovernorVotesComp.sol100%100%100%100%

@apbendi
apbendi merged commit 15a6908 into main Jul 10, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants