Repository navigation
Certora audit fixes - #83
Merged
Merged
Conversation
…ernor` (#71) * fix: inherit BasicCouncilVetoGovernor instead of duplication * refactor: abstract MAIN_DAO_TOKEN type from IERC5805 to address * test: add unit tests * compoundify --------- Co-authored-by: wildmolasses <changes@gmail.com>
* fix: inherit BasicCouncilVetoGovernor instead of duplication * refactor: abstract MAIN_DAO_TOKEN type from IERC5805 to address * test: add unit tests * compoundify * fix: address H-01 as well as H-02, adjust test harness, unit test, integration test * fix: remove proposalEta check, add veto overridden check in _voteSucceeded, update test harness, test --------- Co-authored-by: wildmolasses <changes@gmail.com>
* fix: inherit BasicCouncilVetoGovernor instead of duplication * refactor: abstract MAIN_DAO_TOKEN type from IERC5805 to address * test: add unit tests * compoundify * fix: address H-01 as well as H-02, adjust test harness, unit test, integration test * fix: remove proposalEta check, add veto overridden check in _voteSucceeded, update test harness, test * fix: address H-01 as well as H-02, adjust test harness, unit test, integration test * fix: remove proposalEta check, add veto overridden check in _voteSucceeded, update test harness, test * fix: override council governor proposalEta, add tests --------- Co-authored-by: wildmolasses <changes@gmail.com>
…al-Governor Forwarding (#73) * fix: address H-01 as well as H-02, adjust test harness, unit test, integration test * fix: remove proposalEta check, add veto overridden check in _voteSucceeded, update test harness, test * fix: add explicit return value for _isValidDescriptionForProposer
* fix: reorder heritance in BasicCouncilGovernor state * fix: add _mockVetoGovernorProposalEta
* feat: snapshot extension parameters at proposal creation * use checkpoints * - Clean up `_votingPeriodExtensionThresholdTriggered` - Add OZ-style timpoint based getter for `votingPeriodExtension` and `minorVetoExtensionThresholdPct` - Add unit tests --------- Co-authored-by: wildmolasses <changes@gmail.com>
* fix: add natspec for reducing quorum rounding error * small change --------- Co-authored-by: wildmolasses <changes@gmail.com>
…nded Extension (#82)
funkyenough
force-pushed
the
audit-fixes
branch
from
January 29, 2026 03:05
417b852 to
779bd79
Compare
…enominate Compound params (#86)
|
Coverage after merging audit-fixes into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.