Physics Informed Point Net#875
Open
ka-bear wants to merge 6 commits intoSciML:masterfrom
Open
Conversation
| end | ||
| end | ||
|
|
||
| if GROUP == "All" || GROUP == "PIPN" |
Member
There was a problem hiding this comment.
The .github/workflows/ci.yml needs to add a PIPN group as well for this to run.
Member
|
Looks almost good to go! Left a few comments. |
Member
|
Rebase |
Member
|
Thanks! I will take a look as well in a couple of days. |
Co-authored-by: Christopher Rackauckas <accounts@chrisrackauckas.com>
ChrisRackauckas
force-pushed
the
issue-#495
branch
from
68424b7 to
d4498fb
Compare
sathvikbhagavan
requested changes
Sep 8, 2024
| $(DocStringExtensions.README) | ||
| """ | ||
| module NeuralPDE | ||
| module NeuralPDE |
Member
There was a problem hiding this comment.
Suggested change
| module NeuralPDE | |
| module NeuralPDE |
| include("dgm.jl") | ||
|
|
||
| export NNODE, NNDAE, | ||
| export NNODE, PIPN, init_pipn_params, NNDAE, |
Member
There was a problem hiding this comment.
Suggested change
| export NNODE, PIPN, init_pipn_params, NNDAE, | |
| export NNODE, PIPN, init_pipn_params, NNDAE, |
| ??? | ||
| """ | ||
| struct LogOptions | ||
| struct LogOptions |
Member
There was a problem hiding this comment.
Suggested change
| struct LogOptions | |
| struct LogOptions |
Comment on lines
+560
to
+561
|
|
||
|
|
|
|
||
| ## Positional Arguments | ||
|
|
||
| * `chain`: a Lux chain specifying the overall network architecture. The input and output dimensions |
Member
There was a problem hiding this comment.
Is this even needed as shared mlps are constructed inside?
| global_feature_repeated = repeat(global_feature, 1, size(point_features, 2)) | ||
| combined_features = vcat(point_features, global_feature_repeated) | ||
| combined_features, st3 = Lux.apply(model.after_pool_mlp, combined_features, ps.after_pool_mlp, st.after_pool_mlp) | ||
| output, st4 = Lux.apply(model.final_layer, combined_features, ps.final_layer, st.final_layer) |
Member
There was a problem hiding this comment.
Doesn't the original architecture also have another block of shared mlps?
| flat_ps = ComponentArray(ps) | ||
| new_flat_ps = typeof(flat_ps)(θ) | ||
| return ComponentArray(new_flat_ps) | ||
| end No newline at end of file |
Member
There was a problem hiding this comment.
Suggested change
| end | |
| end | |
| @@ -1,4 +1,4 @@ | |||
| using Pkg | |||
| using Pkg | |||
Member
There was a problem hiding this comment.
Suggested change
| using Pkg | |
| using Pkg |
|
|
||
| @test prob isa OptimizationProblem | ||
| end | ||
| end No newline at end of file |
Member
There was a problem hiding this comment.
Suggested change
| end | |
| end | |
| strategy = GridTraining(0.1) | ||
| discretization = PhysicsInformedNN(chain, strategy) | ||
|
|
||
| prob = discretize(pde_system, discretization) |
Member
There was a problem hiding this comment.
Is it working with solve?
Member
There was a problem hiding this comment.
Ok, cool. Can you add it to the test and also address other comments?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Added PIPNs to NeuralPDE
Fixes: #495