Skip to content

Mooncake ext: handle ComponentVector cotangents in increment_and_get_rdata! #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ChrisRackauckas-Claude wants to merge 1 commit into from
+13 −0
Closed

Mooncake ext: handle ComponentVector cotangents in increment_and_get_rdata! #351

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions ext/ComponentArraysMooncakeExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,19 @@ function Mooncake.increment_and_get_rdata!(
return Mooncake.increment_and_get_rdata!(f.data[:data], r, t)
end

# Same path, but the upstream cotangent has already been wrapped back into a
# `ComponentVector` (e.g. by a `@from_chainrules`/`@from_rrule` rule whose
# rrule returned the gradient as a `ComponentVector` instead of the raw
# backing `Vector`). Strip the wrapper and accumulate into the underlying
# data buffer that the FData is tracking.
function Mooncake.increment_and_get_rdata!(
f::Mooncake.FData{@NamedTuple{data::A, axes::Mooncake.NoFData}},
r::Mooncake.NoRData,
t::ComponentVector{P, A},
) where {P <: Union{Base.IEEEFloat, Complex{<:Base.IEEEFloat}}, A <: Array{P}}
return Mooncake.increment_and_get_rdata!(f.data[:data], r, getdata(t))
end

function Mooncake.friendly_tangent_cache(x::ComponentArray)
Mooncake.FriendlyTangentCache{Mooncake.AsPrimal}(copy(x))
end
Expand Down
Loading