Skip to content

feat: 히스토리 내역을 통한 뒤로가기 분기 처리 - #214

Merged
dasosann merged 2 commits into
mainfrom
fix/back-button
May 29, 2026
Merged

feat: 히스토리 내역을 통한 뒤로가기 분기 처리#214
dasosann merged 2 commits into
mainfrom
fix/back-button

Conversation

@dasosann

Copy link
Copy Markdown
Contributor

요약

구현 사항

  • 뒤로가기 로직 분기처리
  • [ ]
  • [ ]
  • [ ]

📸 스크린샷

Need Review

  • ~ 부분 이렇게 구현했어요, 피드백 부탁해요!

Reference

📜 리뷰 규칙

Reviewer는 아래 P5 Rule을 참고하여 리뷰를 진행합니다.
P5 Rule을 통해 Reviewer는 Reviewee에게 리뷰의 의도를 보다 정확히 전달할 수 있습니다.

  • P1: 꼭 반영해주세요 (Comment)
  • P2: 적극적으로 고려해주세요 (Comment)
  • P3: 웬만하면 반영해 주세요 (Comment)
  • P4: 반영해도 좋고 넘어가도 좋습니다 (Approve)
  • P5: 그냥 사소한 의견입니다 (Approve)

@vercel

vercel Bot commented May 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fe Ready Ready Preview, Comment May 29, 2026 5:02am

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces custom back navigation logic in the ScreenAlbum4Cut component to handle cases where a user enters the page directly (e.g., via a shared link). The reviewer suggested a robust improvement to ensure that document.referrer belongs to the internal origin before calling router.back(), preventing users from being redirected out of the application.

Comment thread src/feature/album/4cut/components/ScreenAlbum4Cut.tsx
@dasosann
dasosann merged commit 85267bf into main May 29, 2026
4 checks passed
@dasosann
dasosann deleted the fix/back-button branch May 29, 2026 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant