Combine Duplicated classes#399
Conversation
|
Looks nice! |
|
@zherczeg |
|
Usually it is a hard task. First thing is reproducing the failing in your side. Then you need to locate the issue. If possible test reduction can help (simplify C code, then recompile). Another way is comparing the original and the new run. Dump the memory (stack) at checkpoints (e.g. at certain instructions), and see whether there is a difference. It is similar to bisecting: a wrong instruction is executed in a range of a correct (the dump of both the old and new code is the same) and incorrect dump. Reduce the range until you locate the instruction. Another way is splitting the patch into small patches, and see which one cause the error. You only need to check that single test. |
|
could you rebase your pr? |
|
@ksh8281 I rebased pr. Please check again! |
| @@ -32,8 +32,10 @@ class FunctionType; | |||
|
|
|||
| #if defined(NDEBUG) | |||
| #define F_NOP(F) | |||
| #define IF_DEBUG_CODE(x) | |||
There was a problem hiding this comment.
I would call it IF_DEBUG_ENABLED.
This PR addresses Current Issues 1 in issues#398https://github.com/Samsung/walrus/issues/398#issue-4125897672.
For this, some macros are defined and functions which has similar content are combined with this macros.
Also, to reduce duplicated codes, parent classes are added.