Skip to content

fix: print to fatal error about console.error #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daeyeon merged 1 commit into from
Sep 17, 2025
Merged

fix: print to fatal error about console.error #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deps/node/lib/internal/bootstrap/switches/is_main_thread.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ function createWritableStdioStream(fd) {
const { Writable } = require('stream');
stream = new Writable({
write(chunk, encoding, callback) {
process.lwnode._print(chunk.toString());
process.lwnode._print(chunk.toString(), this.fd);
callback();
}
});
Expand Down
15 changes: 13 additions & 2 deletions deps/node/src/node_process_methods.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ typedef int mode_t;
#include <termios.h> // tcgetattr, tcsetattr
#endif

#include "trace.h" // @lwnode

namespace node {

using v8::Array;
Expand Down Expand Up @@ -436,10 +438,19 @@ static void ReallyExit(const FunctionCallbackInfo<Value>& args) {
}

void Logger(const FunctionCallbackInfo<Value>& args) {
CHECK(args.Length() == 1 && args[0]->IsString() &&
CHECK(args.Length() > 0 && args[0]->IsString() &&
"must be called with a single string");
Utf8Value message(args.GetIsolate(), args[0]);
FPrintF(stderr, "%s", message);

Environment* env = Environment::GetCurrent(args);

if (args.Length() > 1 && args[1]->IsInt32() &&
args[1]->Int32Value(env->context()).FromJust() == 2) {
// stderr
LWNODE_DEV_FATAL_LOG(message.ToString().c_str());
} else {
FPrintF(stderr, "%s", message);
}
}

static void InitializeProcessMethods(Local<Object> target,
Expand Down