feat: add Runtime::Stop API#102
Merged
daeyeon merged 2 commits intoSamsung:releasefrom Apr 2, 2025
Merged
Conversation
Signed-off-by: Hosung Kim hs852.kim@samsung.com
Signed-off-by: Hosung Kim hs852.kim@samsung.com
daeyeon
reviewed
Apr 2, 2025
Comment on lines
+92
to
+93
| * Stop the runtime. You can use this function to stop the runtime from another | ||
| * thread. |
Member
There was a problem hiding this comment.
Stop the runtime. This function can be used to stop the runtime from another thread safely.
nit: I'd like to suggest to avoid you in API documentation. It's better to use a more neutral and objective phrasing.
Contributor
Author
There was a problem hiding this comment.
Okay. I will fix next commit.
daeyeon
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.