Brage/web 165 mdb frontend features (rerouting, removal of page, profile text)#2143
Open
Brage/web 165 mdb frontend features (rerouting, removal of page, profile text)#2143
Conversation
BragonSB
changed the title
BragonSB
changed the title
aTrueYety
reviewed
Apr 9, 2026
| [KEY.adminpage_connect_mdb_password_notice_1]: 'Your password to the', | ||
| [KEY.adminpage_connect_mdb_password_notice_2]: 'membership database', | ||
| [KEY.adminpage_profile_connected_to_mdb]: "you're connected to", | ||
| [KEY.adminpage_profile_not_connected_to_mdb]: "you're not connected to", |
Contributor
There was a problem hiding this comment.
The translation does not fit the key. Should be KEY.adminpage_profile_connected_to or "you're connected to mdb" meybe.
Contributor
Author
There was a problem hiding this comment.
I disagree, as the key doesn't necessarily need to perfectly fit the translation, but rather tell us what the translation is used for. For example the key-value pair above (adminpage_connect_mdb_password_notice_2 : membership database).
Removing the mdb part from the key would no longer tell us what the translation is supposed to be used for, and it doesn't really fit anywhere else like common
| 'Kunne ikke koble til medlemsdatabasen. Vennligst sjekk at alle felter er skrevet riktig', | ||
| [KEY.adminpage_connect_mdb_password_notice_1]: 'Passordet ditt til ', | ||
| [KEY.adminpage_connect_mdb_password_notice_2]: 'medlemsdatabasen', | ||
| [KEY.adminpage_profile_connected_to_mdb]: 'du er koblet til', |
StenOskar
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: WEB-165