Conversation
|
Sliter med å reviewe siden den er så langt bak master, prøv å merge / rebase på master først. |
Text not centered
Large text blocks overflow
Large part of the title image is covered by the information box
|
|
Would be nice with some docs on how this works (untill the frontend is setup). Would also be nice if the selection of what banner is shown was explained somewhere |
|
aTrueYety
left a comment
aTrueYety
left a comment
There was a problem hiding this comment.
Main thing looks good but some bugs
|
For testing, this is an example of using link: url: /events |
|
To make a banner, go to Django admin site on /admin/samfundet/sitebanner/ |
Simplify SiteBanner to use a single url (and new_tab flag) instead of multiple links and severity. Migration updated. Frontend: styles improved for centering, truncation and responsive layout.
http://localhost:8000/admin/samfundet/sitebanner/
|
|
Meg når jeg ikke tar å migrate ^^ |
aTrueYety
left a comment
aTrueYety
left a comment
There was a problem hiding this comment.
The animation when hiding the banner on scroll is very jumpy
This: 
There was a problem hiding this comment.
-
Når banneret går opp når du skroller kan man se under/ mellom den og navbaren, ser litt goofy ut.
-
kan også være ide å legge til en ease sånn at animasjonen ikke er så voldsom.
-
En litt lengere max tekst kunne ikke skade heller, noe som 150 ellerno.
ellers clean :DDD
Convert site banners to a single active banner flow and update frontend integration. Backend: remove is_active/UUID id, make start_at required, increase text length, remove is_active from serializer and admin list_display, and update migration accordingly; SiteBannerView.active now returns a single banner (first) or null. Frontend: add SiteBanner DTO, query key, and getActiveSiteBanner API; use react-query to fetch the active banner, render localized text via dbT
|
Når man endrer språk blir ikke språket på bannere endret |
|
litt random men med brukt av en tab eller usynlig karakter så vil det bare vises en tynn rød bar, sikkert ikke viktig men ennå noe å tenke på. |
| return response.data; | ||
| } | ||
|
|
||
| export async function getActiveSiteBanner(): Promise<SiteBannerDto | null> { |
There was a problem hiding this comment.
hadde vært fint med en funksjon som returnerer alle bannere i databasen for senere bruk, ikke hast.
0xSpecter
left a comment
0xSpecter
left a comment
There was a problem hiding this comment.
Ser bra ut, par små ting som ikke er noe big deal.
4 participants
Adds support for site-wide banners managed through Django admin.
Notes