Skip to content

Create event publication date before event date no clear#2102

Open
leaesc wants to merge 3 commits intomasterfrom
leaesc/web-83-create-event-publication-date-before-event-date-no-clear
Open

Create event publication date before event date no clear#2102
leaesc wants to merge 3 commits intomasterfrom
leaesc/web-83-create-event-publication-date-before-event-date-no-clear

Conversation

@leaesc
Copy link
Copy Markdown
Contributor

@leaesc leaesc commented Mar 5, 2026

Closing: WEB-83

@leaesc leaesc requested review from andsamfu and robines as code owners March 5, 2026 20:49
@leaesc leaesc requested a review from eilifhl March 5, 2026 20:50
Copy link
Copy Markdown
Contributor

@eilifhl eilifhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fint jobba! Ser ut som at du har fått med noen endringer fra dine andre PRer, som ikke er relatert til dette.
Dette har antagelig skjedd fordi du gjorde git checkout leaesc/web-83-xyz fra din andre branch leaesc/web-111 og ikke master, og da får du med alle endringene fra den andre branchen

Comment thread frontend/src/i18n/constants.ts Outdated
Comment thread frontend/src/Pages/ContributorsPage/ContributorsPage.tsx
Comment thread frontend/src/Pages/EventsPage/components/EventsList/EventsList.tsx Outdated
@leaesc leaesc force-pushed the leaesc/web-83-create-event-publication-date-before-event-date-no-clear branch from fe5f697 to 75ca759 Compare March 12, 2026 16:28
@leaesc leaesc requested a review from eilifhl March 12, 2026 16:30
@robines robines changed the title Leaesc/web 83 create event publication date before event date no clear Create event publication date before event date no clear Mar 24, 2026
Comment thread frontend/src/PagesAdmin/EventCreatorAdminPage/EventCreatorAdminPage.tsx Outdated
Comment thread frontend/src/PagesAdmin/EventCreatorAdminPage/EventCreatorAdminPage.tsx Outdated
Comment thread frontend/src/PagesAdmin/EventCreatorAdminPage/EventCreatorAdminPage.tsx Outdated
Comment thread frontend/src/PagesAdmin/EventCreatorAdminPage/EventCreatorSchema.ts Outdated
Comment thread frontend/src/PagesAdmin/EventCreatorAdminPage/EventCreatorSchema.ts Outdated
Comment thread frontend/src/PagesAdmin/EventCreatorAdminPage/EventCreatorSchema.ts Outdated
@leaesc leaesc requested a review from aTrueYety April 7, 2026 18:08
Copy link
Copy Markdown
Contributor

@aTrueYety aTrueYety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon of the last segment does not indicate errors like the other segments do.

Image

Otherwise looking guuud

return true;
},
{
message: 'Publication date must be before event start date!',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add tranlations to this message with new changes in master. See frontend/src/schema/event.ts in master for an example.

Copy link
Copy Markdown
Contributor

@0xSpecter 0xSpecter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Er det en mulighet for å gjøre start_dt og visibility_dt til en Date tidligere i løypa sånn at vi slipper å gjøre strengen om til en Date flere ganger. (Ps gjore dette fra telefonen så kan ikke sjekke datatype:DDD, hyttetur hype)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants