Conversation
BragonSB
left a comment
BragonSB
left a comment
There was a problem hiding this comment.
Very nice, a few things to look at though, the translation thingy might be out of scope and better to do in a seperate issue like WEB-130
BragonSB
left a comment
BragonSB
left a comment
There was a problem hiding this comment.
Very nice approved, just a few things to look at:)
| const SOCIAL_LABELS: Record<SocialLinkKey, string> = { | ||
| spotify_uri: 'Spotify URI', | ||
| youtube_link: 'YouTube link', | ||
| youtube_embed: 'YouTube embed', | ||
| facebook_link: 'Facebook link', | ||
| soundcloud_link: 'SoundCloud link', | ||
| instagram_link: 'Instagram link', | ||
| x_link: 'X link', | ||
| lastfm_link: 'Last.fm link', | ||
| vimeo_link: 'Vimeo link', | ||
| general_link: t(KEY.event_general_link), | ||
| }; |
There was a problem hiding this comment.
Bruke translation her? Er vell egentlig "lenke" istedenfor "link" på norsk. Usikker på "Spotify URI" og "YouTube embed" for det blir jo likt mellom norsk og engelsk.
Har lav betydning, for folk forstår "link".
There was a problem hiding this comment.
La til oversettelse for link/lenke nå
| const SOCIAL_FIELDS = [ | ||
| 'spotify_uri', | ||
| 'youtube_link', | ||
| 'youtube_embed', | ||
| 'facebook_link', | ||
| 'soundcloud_link', | ||
| 'instagram_link', | ||
| 'x_link', | ||
| 'lastfm_link', | ||
| 'vimeo_link', | ||
| 'general_link', | ||
| ] as const; |
There was a problem hiding this comment.
Er samme liste som i SocialMediaStep.tsx. Har derfor to av samme listen man må vedlikeholde.
Forslag er å heller eksportere listen fra SocialMediaStep.tsx og importere her slik at det kun blir en liste å vedlikeholde.
| .gridItemFull { | ||
| grid-column: 1 / -1; | ||
| } | ||
|
|
||
| .gridItemFull .socialGrid { | ||
| max-width:max-content ; | ||
| } |
There was a problem hiding this comment.
Kan ikke se at dette har blitt brukt noe sted. Fjerne?
Lav viktighet.
There was a problem hiding this comment.
Ja, glemte å fjerne så fjernet dem nå
| } | ||
|
|
||
|
|
||
| .half { |
There was a problem hiding this comment.
Funnet noen steder med ekstra tomme linjer i denne filen. Kjøre linter?
Lav viktighet.
4 participants
No description provided.