Skip to content

[autobackport: sssd-2-13] ci: update passkey TMT plan for native CentOS Stream 10 execution#8787

Merged
justin-stephenson merged 4 commits into
SSSD:sssd-2-13from
sssd-bot:SSSD-sssd-backport-pr8731-to-sssd-2-13
Jun 9, 2026
Merged

[autobackport: sssd-2-13] ci: update passkey TMT plan for native CentOS Stream 10 execution#8787
justin-stephenson merged 4 commits into
SSSD:sssd-2-13from
sssd-bot:SSSD-sssd-backport-pr8731-to-sssd-2-13

Conversation

@sssd-bot

@sssd-bot sssd-bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

This is an automatic backport of PR#8731 ci: update passkey TMT plan for native CentOS Stream 10 execution to branch sssd-2-13, created by @ikerexxe.

Please make sure this backport is correct.

Note

The commits were cherry-picked without conflicts.

You can push changes to this pull request

git remote add sssd-bot git@github.com:sssd-bot/sssd.git
git fetch sssd-bot refs/heads/SSSD-sssd-backport-pr8731-to-sssd-2-13
git checkout SSSD-sssd-backport-pr8731-to-sssd-2-13
git push sssd-bot SSSD-sssd-backport-pr8731-to-sssd-2-13 --force

Original commits
334449b - ci: fix error handling in passkey TMT plan SSH commands
167b5a9 - ci: use hardware.memory syntax for TMT passkey tests
943ecbb - ci: update passkey TMT plan for native CentOS Stream 10 execution

Backported commits

  • 665f587 - ci: fix error handling in passkey TMT plan SSH commands
  • d60c58a - ci: use hardware.memory syntax for TMT passkey tests
  • 116e459 - ci: update passkey TMT plan for native CentOS Stream 10 execution

Original Pull Request Body

  • With 16GB RAM allocation, CentOS Stream 10 tests can now run directly on matching VM and containers. Thus, update distribution detection to use distro.sh script.
  • If COPR_ENABLE_CMD fails, the script will now fail immediately instead of proceeding to dnf upgrade with packages from default repositories, ensuring tests run against the correct SSSD version. Reported in [autobackport: sssd-2-13] ci: add TMT plan for passkey testing in PRCI #8728 (comment)

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the Packit configuration by integrating the centos-stream-10 target directly into the main test job. It also updates the passkey.fmf test plan to use the new hardware requirements format, dynamically detect the distribution (Fedora vs. CentOS Stream) for setting container tags and COPR commands, enable EPEL on CentOS Stream, and chain SSH commands safely. Feedback was provided regarding the restriction of loading the vhci_hcd kernel module to Fedora only, which would cause CentOS Stream 10 executions to fail since it also requires this module. A suggestion was made to support both Fedora and CentOS.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread plans/passkey.fmf

@jakub-vavra-cz jakub-vavra-cz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ikerexxe added 4 commits June 9, 2026 14:58
If COPR_ENABLE_CMD fails, the script will now fail immediately instead
of proceeding to dnf upgrade with packages from default repositories,
ensuring tests run against the correct SSSD version.

Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Reviewed-by: Jakub Vávra <jvavra@redhat.com>
Reviewed-by: Justin Stephenson <jstephen@redhat.com>
(cherry picked from commit 334449b)
Update passkey.fmf to use the `hardware.memory` specification. Changed
from fixed 16GB to ">= 16 GB" requirement as per Testing Farm
documentation at
https://docs.testing-farm.io/Testing%20Farm/0.1/test-request.html#ram

Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Reviewed-by: Jakub Vávra <jvavra@redhat.com>
Reviewed-by: Justin Stephenson <jstephen@redhat.com>
(cherry picked from commit 167b5a9)
With 16GB RAM allocation, CentOS Stream 10 tests can now run directly on
matching VM and containers. Thus, update the plan to take this into
account and detect the distribution accordingly.

Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Reviewed-by: Jakub Vávra <jvavra@redhat.com>
Reviewed-by: Justin Stephenson <jstephen@redhat.com>
(cherry picked from commit 943ecbb)
Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Reviewed-by: Jakub Vávra <jvavra@redhat.com>
Reviewed-by: Justin Stephenson <jstephen@redhat.com>
@sssd-bot

sssd-bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

The pull request was accepted by @justin-stephenson with the following PR CI status:


🟢 rpm-build:centos-stream-10-x86_64:upstream (success)
🟢 rpm-build:fedora-43-x86_64:upstream (success)
🟢 rpm-build:fedora-44-x86_64:upstream (success)
🟢 rpm-build:fedora-rawhide-x86_64:upstream (success)
🟢 testing-farm:centos-stream-10-x86_64:upstream (success)
🟢 testing-farm:fedora-43-x86_64:upstream (success)
🟢 testing-farm:fedora-44-x86_64:upstream (success)
🟢 testing-farm:fedora-rawhide-x86_64:upstream (success)
🟢 Build / freebsd (success)
🟢 Build / make-distcheck (success)


There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@sssd-bot sssd-bot force-pushed the SSSD-sssd-backport-pr8731-to-sssd-2-13 branch from e9dc329 to 8c25081 Compare June 9, 2026 14:59
@justin-stephenson justin-stephenson merged commit d89021c into SSSD:sssd-2-13 Jun 9, 2026
3 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants