Skip to content

[autobackport: sssd-2-12] ci: update passkey TMT plan for native CentOS Stream 10 execution#8786

Merged
justin-stephenson merged 3 commits into
SSSD:sssd-2-12from
sssd-bot:SSSD-sssd-backport-pr8731-to-sssd-2-12
Jun 9, 2026
Merged

[autobackport: sssd-2-12] ci: update passkey TMT plan for native CentOS Stream 10 execution#8786
justin-stephenson merged 3 commits into
SSSD:sssd-2-12from
sssd-bot:SSSD-sssd-backport-pr8731-to-sssd-2-12

Conversation

@sssd-bot

@sssd-bot sssd-bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

This is an automatic backport of PR#8731 ci: update passkey TMT plan for native CentOS Stream 10 execution to branch sssd-2-12, created by @ikerexxe.

Caution

@ikerexxe The patches did not apply cleanly. It is necessary to resolve conflicts before merging this pull request. Commits that introduced conflict are marked with CONFLICT!.

You can push changes to this pull request

git remote add sssd-bot git@github.com:sssd-bot/sssd.git
git fetch sssd-bot refs/heads/SSSD-sssd-backport-pr8731-to-sssd-2-12
git checkout SSSD-sssd-backport-pr8731-to-sssd-2-12
git push sssd-bot SSSD-sssd-backport-pr8731-to-sssd-2-12 --force

Original commits
334449b - ci: fix error handling in passkey TMT plan SSH commands
167b5a9 - ci: use hardware.memory syntax for TMT passkey tests
943ecbb - ci: update passkey TMT plan for native CentOS Stream 10 execution

Backported commits

  • fb84def - ci: fix error handling in passkey TMT plan SSH commands
  • a312ffb - ci: use hardware.memory syntax for TMT passkey tests
  • 785b212 - CONFLICT! ci: update passkey TMT plan for native CentOS Stream 10 execution

Conflicting Files Information (check for deleted and re-added files)

  • CONFLICT! ci: update passkey TMT plan for native CentOS Stream 10 execution
On branch SSSD-sssd-backport-pr8731-to-sssd-2-12
You are currently cherry-picking commit 943ecbb36.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   plans/passkey.fmf

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .packit.yaml

Original Pull Request Body

  • With 16GB RAM allocation, CentOS Stream 10 tests can now run directly on matching VM and containers. Thus, update distribution detection to use distro.sh script.
  • If COPR_ENABLE_CMD fails, the script will now fail immediately instead of proceeding to dnf upgrade with packages from default repositories, ensuring tests run against the correct SSSD version. Reported in [autobackport: sssd-2-13] ci: add TMT plan for passkey testing in PRCI #8728 (comment)

@packit-as-a-service

Copy link
Copy Markdown

Failed to load packit config file:

Please correct data and retry.

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command config validate or our pre-commit hooks for validation of the configuration.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the passkey TMT plan to support native CentOS Stream 10 execution. Key changes include updating memory provisioning requirements, enabling the EPEL repository on CentOS Stream, restricting Fedora-specific kernel module loading, and dynamically detecting the system distribution to set container tags and COPR commands. Additionally, command execution in SSH blocks was chained with &&. Note that git merge conflict markers were accidentally left in .packit.yaml and should be resolved. There are no review comments to address, so no further feedback is provided.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@ikerexxe ikerexxe force-pushed the SSSD-sssd-backport-pr8731-to-sssd-2-12 branch 2 times, most recently from 7ea90cc to 3947dc6 Compare June 9, 2026 08:52
@ikerexxe ikerexxe marked this pull request as ready for review June 9, 2026 12:27

@jakub-vavra-cz jakub-vavra-cz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

ikerexxe added 3 commits June 9, 2026 15:00
If COPR_ENABLE_CMD fails, the script will now fail immediately instead
of proceeding to dnf upgrade with packages from default repositories,
ensuring tests run against the correct SSSD version.

Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Reviewed-by: Jakub Vávra <jvavra@redhat.com>
Reviewed-by: Justin Stephenson <jstephen@redhat.com>
(cherry picked from commit 334449b)
Update passkey.fmf to use the `hardware.memory` specification. Changed
from fixed 16GB to ">= 16 GB" requirement as per Testing Farm
documentation at
https://docs.testing-farm.io/Testing%20Farm/0.1/test-request.html#ram

Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Reviewed-by: Jakub Vávra <jvavra@redhat.com>
Reviewed-by: Justin Stephenson <jstephen@redhat.com>
(cherry picked from commit 167b5a9)
With 16GB RAM allocation, CentOS Stream 10 tests can now run directly on
matching VM and containers. Thus, update the plan to take this into
account and detect the distribution accordingly.

Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Reviewed-by: Jakub Vávra <jvavra@redhat.com>
Reviewed-by: Justin Stephenson <jstephen@redhat.com>
(cherry picked from commit 943ecbb)
@sssd-bot

sssd-bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

The pull request was accepted by @justin-stephenson with the following PR CI status:


🟢 rpm-build:centos-stream-10-x86_64:upstream (success)
🟢 rpm-build:fedora-43-x86_64:upstream (success)
🟢 rpm-build:fedora-44-x86_64:upstream (success)
🟢 rpm-build:fedora-rawhide-x86_64:upstream (success)
🟢 testing-farm:centos-stream-10-x86_64:upstream (success)
🟢 Build / freebsd (success)
🟢 Build / make-distcheck (success)


There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@sssd-bot sssd-bot force-pushed the SSSD-sssd-backport-pr8731-to-sssd-2-12 branch from 3947dc6 to 4197421 Compare June 9, 2026 15:00
@justin-stephenson justin-stephenson merged commit 8f49f7e into SSSD:sssd-2-12 Jun 9, 2026
3 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants