Replace umockdev with vfido for passkey testing#237
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request migrates the passkey testing infrastructure to use Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates the passkey testing infrastructure from umockdev to vfido, which is a more modern and robust solution. The changes are well-structured, covering documentation, feature detection, and the authentication utilities themselves. I've identified a few areas for improvement, mainly around documentation consistency and simplifying some of the expect scripts for better readability and maintenance.
ikerexxe
force-pushed
the
test-passkey-vfido
branch
2 times, most recently
from
49c7701 to
fb4f3b8
Compare
ikerexxe
force-pushed
the
test-passkey-vfido
branch
from
fb4f3b8 to
31ca605
Compare
|
In general looks good to me. See a couple of remarks/questions inline. |
ikerexxe
force-pushed
the
test-passkey-vfido
branch
from
31ca605 to
d0de6a3
Compare
|
ACK |
ikerexxe
force-pushed
the
test-passkey-vfido
branch
2 times, most recently
from
602ba9c to
e485bb7
Compare
spoore1
left a comment
spoore1
left a comment
There was a problem hiding this comment.
Still reviewing but wanted to post this so it's not lost.
Update `vfido_passkey_add_register()` to return the passkey mapping, just as `umockdev_passkey_add_register()` does Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Fix authentication routing bug that prevented vfido from being used correctly Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
PASSKEY_FALLBACK_TO_PASSWORD requires a PIN, even though this might be an empty or wrong PIN. Fix this by grouping PASSKEY_FALLBACK_TO_PASSWORD with PIN requiring auth methods. Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
Previous implementation for the bash code was a little bit confusing and didn't make much sense from the high-level perspective. Refactored the function to follow phases, some of them are mandatory for all methods, other are only required for some of the methods. Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
`vfido` feature needs `vhci_hcd` kernel module to be loaded to work, thus adding a check there Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
The virtual FIDO2 authenticator has been replaced by vfido, thus update the documentation Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com>
ikerexxe
force-pushed
the
test-passkey-vfido
branch
from
e485bb7 to
f887615
Compare
spoore1
left a comment
spoore1
left a comment
There was a problem hiding this comment.
LGTM. I ran tests with the SSSD PR#8510 using Fedora containers and only 1 failure which I think may be handled in the test:
FAILED tests/test_passkey.py::test_passkey__ipa_server_offline (ipa) - AssertionError: Credential cache found
============================================================================ 1 failed, 48 passed, 874 deselected in 1484.03s (0:24:44) =============================================================================
I'll rebase and clean up everything on SSSD/sssd#8510. If the test still fails I'll check it and see how to fix it. Merging... |
4 participants
Migrate the passkey testing infrastructure from
umockdevtovfido, providing a more robust and reliable solution for passkey authentication testing. The migration includes updating client feature detection to supportvfido's requirements, refactoring authentication utilities for improved integration, and updating the documentation to reflect the newvfidousage patterns. These changes enhance the overall passkey testing experience while maintaining backward compatibility where applicable.SSSD PRCI run for these changes is available in SSSD/sssd#8510