Open
Conversation
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
There was a problem hiding this comment.
Pull request overview
Continues the Invite-to-Interview (I2I) / Invite-to-Apply (I2A) refactor by standardizing URL params (inviteAction, type), consolidating shared UI into a new InviteToLayout, and adding the new I2I “Next Steps” response page flow while updating the backend message service method naming.
Changes:
- Renames/refactors backend messaging entrypoints from
send_invite_to_responsetosend_invite_to_apply_responseand updates controller/spec call sites. - Refactors Invite-to React pages into shared components (
InviteToLayout, shared withdrawn/contact pages) and addsInviteToInterviewNextSteps. - Updates routing/link generation to carry
typeand switches frontend to the newinviteActionparam +INVITE_TO_Xenum.
Reviewed changes
Copilot reviewed 24 out of 25 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| spec/services/dahlia_backend/message_service_spec.rb | Updates specs for renamed messaging methods. |
| spec/controllers/invite_to_controller_spec.rb | Updates controller spec params to inviteAction, adjusts expectations, leaves TODO blocks. |
| spec/controllers/api/v1/invite_to_response_controller_spec.rb | Updates API controller spec to use renamed messaging method. |
| app/services/dahlia_backend/message_service.rb | Renames invite-to messaging method and adjusts endpoint selection / field prep. |
| app/controllers/invite_to_controller.rb | Refactors params to inviteAction and renames upload URL prop to url; token decode currently commented out. |
| app/controllers/api/v1/invite_to_response_controller.rb | Updates API to call renamed messaging method. |
| app/javascript/util/routeUtil.ts | Updates generateSubmitLink to include type in querystring when no token is used. |
| app/javascript/util/listingUtil.ts | Updates comment to “I2X deadlines”. |
| app/javascript/pages/inviteTo/invite-to.tsx | Main Invite-to router refactor: INVITE_TO_X, inviteAction, I2I gating via Unleash variant JSON payload. |
| app/javascript/pages/inviteTo/InviteToLayout.tsx | New shared layout for I2A/I2I next steps pages. |
| app/javascript/pages/inviteTo/inviteToApply/InviteToApplyNextSteps.tsx | Refactors I2A next steps to use InviteToLayout + unified recordResponse API. |
| app/javascript/pages/inviteTo/inviteToInterview/InviteToInterviewNextSteps.tsx | New I2I next steps page with scheduling CTA + recordResponse. |
| app/javascript/pages/inviteTo/InviteToWithdrawn.tsx | New shared withdrawn page supporting I2A/I2I content. |
| app/javascript/pages/inviteTo/InviteToContactMeLater.tsx | New shared contact-me-later / waitlist page supporting I2A/I2I content. |
| app/javascript/pages/inviteTo/InviteToLeasingAgentInfo.tsx | Renames shared leasing agent info component. |
| app/javascript/pages/inviteTo/InviteToDeadlinePassed.tsx | Updates import for renamed leasing agent info component. |
| app/javascript/modules/constants.tsx | Adds INVITE_TO_X enum (I2A, I2I). |
| app/javascript/api/types/rails/listings/BaseRailsListing.d.ts | Adds optional Leaseup_Appointment_Scheduling_URL. |
| app/javascript/api/inviteToApiService.ts | Keeps unified recordResponse API (removes outdated comment). |
| app/javascript/tests/pages/invite-to-interview.test.tsx | Updates and expands I2I page tests for new flow. |
| app/javascript/tests/pages/invite-to-apply.test.tsx | Updates I2A tests for inviteAction + INVITE_TO_X + type in preview link. |
| app/javascript/tests/api/inviteToApplyApiService.test.ts | Updates test to target inviteToApiService (filename now mismatched). |
| app/assets/json/translations/react/en.json | Updates I2I deadline info string formatting. |
Comments suppressed due to low confidence (1)
app/javascript/pages/inviteTo/inviteToApply/InviteToApplyNextSteps.tsx:86
handleSubmitClickopens the upload URL before the API call and then opens it again in thecatch, which will create duplicate tabs/windows on failures. Also,urlcan beundefinedif neitherfileUploadUrlnorlisting.File_Upload_URLis present, which will open a blank tab. Add a guard for missing URL and ensure the link is opened only once.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Continued I2I/I2A refactoring and response pages frontend.
Note: this PR builds on #2862
New strings need an engineer with Phrase access to push.
Jira ticket
https://sfgovdt.jira.com/browse/DAH-4037
Before requesting eng review
Version Control
angularif it contains updates to Angular codetype: TICKET-NUMBER Descriptionformat, useDAH-000if it does not need a ticketurgent: Descriptionformat if it is urgent and does not need a ticketCode quality
Code conventions
.scssstylesheets andui-seedstokens, rather than inline styles or TailwindReview instructions
Request eng review
needs reviewlabelHousing Enggroup to automatically assign reviewers, and/or assign specific engineersBefore merging
Request product acceptance (PA) testing
needs product acceptancelabel)