Skip to content

fix: DAH-3919 Fix contact side panel#2857

Open
josh-chou wants to merge 1 commit intomainfrom
DAH-3919-fix-contact-side-panel
Open

fix: DAH-3919 Fix contact side panel#2857
josh-chou wants to merge 1 commit intomainfrom
DAH-3919-fix-contact-side-panel

Conversation

@josh-chou
Copy link
Copy Markdown
Collaborator

@josh-chou josh-chou commented Apr 9, 2026

Description

Adjusts padding of aside element on i2a submit your info page.

Jira ticket

https://sfgovdt.jira.com/browse/DAH-3919

Before requesting eng review

Version Control

  • branch name begins with angular if it contains updates to Angular code
  • branch name contains the Jira ticket number
  • PR name follows type: TICKET-NUMBER Description format, use DAH-000 if it does not need a ticket
  • PR name follows urgent: Description format if it is urgent and does not need a ticket

Code quality

  • the set of changes is small
  • all automated code checks pass (linting, tests, coverage, etc.)
  • if the PR is a bugfix, there are tests and logs around the bug

Code conventions

  • web pages are formatted with .scss stylesheets and ui-seeds tokens, rather than inline styles or Tailwind

Review instructions

  • instructions specify which environment(s) it applies to
  • instructions work for PA testers
  • instructions have already been performed at least once

Request eng review

  • PR has needs review label
  • Use Housing Eng group to automatically assign reviewers, and/or assign specific engineers
  • If time sensitive, notify engineers in Slack

Before merging

Request product acceptance (PA) testing

  • PA tested in the review environment (use needs product acceptance label)
  • if PA testing cannot be done, changes are behind a feature flag

@hshaosf hshaosf temporarily deployed to dahlia-webapp-pr-2857 April 9, 2026 20:51 Inactive
@josh-chou josh-chou added needs review Pull request needs review needs product acceptance Pull request requires product acceptance before merging and removed needs product acceptance Pull request requires product acceptance before merging labels Apr 9, 2026
@josh-chou josh-chou requested review from a team, cliu02 and jimlin-sfgov and removed request for a team April 9, 2026 21:07
@josh-chou josh-chou marked this pull request as ready for review April 9, 2026 21:08
Copilot AI review requested due to automatic review settings April 9, 2026 21:08
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the layout styling for the Invite To Apply “Submit your info” (and any other pages sharing the same sidebar class) by changing the desktop padding applied to the sidebar/aside container.

Changes:

  • Updated .submitYourInfoSidebar padding in the invite-to-apply SCSS module to alter spacing around the sidebar content.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread app/javascript/pages/inviteToApply/invite-to-apply.module.scss
Copy link
Copy Markdown
Collaborator

@jimlin-sfgov jimlin-sfgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review Pull request needs review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants