[TTYP] Add ABAP file format for table types#775
Open
GuilhermeSaraiva96 wants to merge 3 commits intomainfrom
Open
[TTYP] Add ABAP file format for table types#775GuilhermeSaraiva96 wants to merge 3 commits intomainfrom
GuilhermeSaraiva96 wants to merge 3 commits intomainfrom
Conversation
Adds ZIF_AFF_TTYP_V1 interface, JSON schema, example, and README for ABAP Dictionary table types (TTYP).
ABAP Doc Checks
|
AFF Review ProcessThank you for your contribution to the ABAP File Formats! 🎉 To help us manage reviews efficiently:
|
Control PanelHi, I'm an AI-powered Review Bot that helps you with summarizing and reviewing pull requests.
|
larshp
reviewed
Apr 29, 2026
Comment on lines
+179
to
+192
| BEGIN OF ty_built_in_type, | ||
| "! <p class="shorttext">Data Type</p> | ||
| "! ABAP built-in data type name (e.g. CHAR, INT4, STRING) | ||
| "! $required | ||
| data_type TYPE c LENGTH 10, | ||
| "! <p class="shorttext">Length</p> | ||
| "! Length of the built-in type (relevant for length-variable types such as CHAR, NUMC) | ||
| "! $minimum 0 | ||
| length TYPE i, | ||
| "! <p class="shorttext">Decimals</p> | ||
| "! Number of decimal places (relevant for DEC, CURR, QUAN) | ||
| "! $minimum 0 | ||
| decimals TYPE i, | ||
| END OF ty_built_in_type. |
Collaborator
There was a problem hiding this comment.
I think this part can be reused from #727 when its merged
| general_information TYPE ty_general_information, | ||
| "! <p class="shorttext">Initialization and Access</p> | ||
| "! Access type and initial fill size | ||
| init_and_access TYPE ty_init_and_access, |
Contributor
There was a problem hiding this comment.
Suggested change
| init_and_access TYPE ty_init_and_access, | |
| initialization_and_access TYPE ty_init_and_access, |
| row_type TYPE ty_row_type, | ||
| "! <p class="shorttext">Initialization and Access</p> | ||
| "! Access type and initial fill size | ||
| init_and_access TYPE ty_init_and_access, |
Contributor
There was a problem hiding this comment.
Suggested change
| init_and_access TYPE ty_init_and_access, | |
| initialization_and_access TYPE ty_initialization_and_access, |
| primary_key TYPE ty_primary_key, | ||
| "! <p class="shorttext">Further Secondary Keys</p> | ||
| "! Whether additional secondary keys beyond those listed may be defined at usage | ||
| sec_keys_allowed TYPE ty_sec_keys_allowed, |
Contributor
There was a problem hiding this comment.
Suggested change
| sec_keys_allowed TYPE ty_sec_keys_allowed, | |
| secondary_keys_allowed TYPE abap_bool, |
| "! Primary key definition | ||
| primary_key TYPE ty_primary_key, | ||
| "! <p class="shorttext">Further Secondary Keys</p> | ||
| "! Whether additional secondary keys beyond those listed may be defined at usage |
Contributor
There was a problem hiding this comment.
It is hard to understand this description. The sentence should be rephrased
Contributor
Author
There was a problem hiding this comment.
AI slop ;)
| "! <p class="shorttext">Primary Key</p> | ||
| "! Primary key definition | ||
| primary_key TYPE ty_primary_key, | ||
| "! <p class="shorttext">Further Secondary Keys</p> |
Contributor
There was a problem hiding this comment.
Suggested change
| "! <p class="shorttext">Further Secondary Keys</p> | |
| "! <p class="shorttext">Secondary Keys allowed</p> |
| definition TYPE ty_prim_key_definition, | ||
| "! <p class="shorttext">Key Uniqueness</p> | ||
| "! Whether the primary key is unique or non-unique | ||
| kind TYPE ty_key_kind, |
Contributor
There was a problem hiding this comment.
Suggested change
| kind TYPE ty_key_kind, | |
| uniqueness TYPE ty_key_uniqueness, |
| description TYPE zif_aff_types_v1=>ty_description_80, | ||
| "! <p class="shorttext">Access Type</p> | ||
| "! Access type of the secondary key | ||
| access TYPE ty_sec_key_access, |
Contributor
There was a problem hiding this comment.
Suggested change
| access TYPE ty_sec_key_access, | |
| access_type TYPE ty_secondary_key_access, |
| "! Access type of the secondary key | ||
| access TYPE ty_sec_key_access, | ||
| "! <p class="shorttext">Key Definition</p> | ||
| "! How the secondary key fields are determined |
Contributor
There was a problem hiding this comment.
Suggested change
| "! How the secondary key fields are determined | |
| "! Key definition |
| "! Definition of the table line type | ||
| BEGIN OF ty_row_type, | ||
| "! <p class="shorttext">Type Kind</p> | ||
| "! How the row type is specified |
Contributor
There was a problem hiding this comment.
Suggested change
| "! How the row type is specified | |
| "! Type kind |
|
|
||
| "! <p class="shorttext">Key Components</p> | ||
| "! Explicitly named key field components | ||
| ty_key_components TYPE STANDARD TABLE OF ty_key_component WITH DEFAULT KEY. |
Contributor
There was a problem hiding this comment.
Suggested change
| ty_key_components TYPE STANDARD TABLE OF ty_key_component WITH DEFAULT KEY. | |
| ty_key_components TYPE STANDARD TABLE OF zif_aff_types_v1=>ty_object_name_30 WITH DEFAULT KEY. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ZIF_AFF_TTYP_V1ABAP interface defining the file format for ABAP Dictionary table types (TTYP)ttyp-v1.jsonz_aff_example_ttyp.ttyp.json(sorted table with explicit key components)README.mdwith file structure documentation