Make Probe.disable() clear the _enabled flag, and correct the socket.io probe name in the README - #663
Open
Megapixel99 wants to merge 3 commits into
Open
Make Probe.disable() clear the _enabled flag, and correct the socket.io probe name in the README#663Megapixel99 wants to merge 3 commits into
Megapixel99 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small fixes:
Probe.prototype.disable()stubbed out the metrics hooks but never clearedthe
_enabledflag those hooks are restored from, so a disabled probe couldsilently come back on.
socketio, but the proberegisters itself as
socket.io, so the documentedenable/disablevaluenever matched.
1.
lib/probe.js—disable()leaves_enabledtrueenable()anddisable()are asymmetric: