Skip to content

docs: clarify safe-links and path protection - #1156

Merged
steadytao merged 1 commit into
masterfrom
clarify-safe-links
Nov 9, 2026
Merged

steadytao merged 1 commit into
masterfrom
clarify-safe-links

Conversation

@steadytao

@steadytao steadytao commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

Fixes - #1154

@steadytao

Copy link
Copy Markdown
Member Author

@bahbarnett is that better or do you notice any leftover ambiguity?

@seks99x

seks99x commented Nov 9, 2026

Copy link
Copy Markdown
Member

Could you also specify more about how trusted symlinks definition differ between non confined root and confined root transfers because there is a lot of mis-conception here. Trusted symlinks is different when we are talking about confined root transfer (--confine-root or daemon) which only follows a link under two conditions: symlink owned by root or the running uid and the symlink is pointing inside the confined root. Non confined root transfer only requires the link to be owned by a trusted user.
Untrusted symlinks behavior also differ between source and dest path. Path like "rsync non-trusted-symlink/ dest/" would not error, however "rsync src/ non-trusted-symlink" would error without insecure-links.

@steadytao
steadytao force-pushed the clarify-safe-links branch 2 times, most recently from 24c4b44 to 0fcb045 Compare November 9, 2026 17:20
@steadytao

steadytao commented Nov 9, 2026 •

Copy link
Copy Markdown
Member Author

@seks99x source/destination distinction was already corrected but added a cross-reference for confined transfers instead of duplicating the full confined root and daemon rules here.

Comment thread rsync.1.md Resolved
@seks99x

seks99x commented Nov 9, 2026

Copy link
Copy Markdown
Member

Thanks a lot. LGTM

@steadytao

Copy link
Copy Markdown
Member Author

Thank you for the review.

@steadytao
steadytao merged commit 9d10a1e into master Nov 9, 2026
14 checks passed
@steadytao
steadytao deleted the clarify-safe-links branch November 9, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants