Skip to content

[Docs] Clarify provider credential fingerprint security model #1549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrubens merged 3 commits into from
Aug 23, 2026
+4 −0
Merged

[Docs] Clarify provider credential fingerprint security model #1549

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
867662b
fix: suppress provider fingerprint CodeQL false positive
roomote Aug 23, 2026
d0e99d3
fix: anchor CodeQL suppression to alert line
roomote Aug 23, 2026
f46685d
docs: clarify provider fingerprint security semantics
roomote Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/db/src/lib/provider-credential-fingerprint.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,13 @@

import { getEncryptionKey } from '@roomote/env';

/**
* Returns a stable, non-secret identifier for grouping provider credentials.
* This is not a password hash and must remain deterministic for lookups.
*/
export function fingerprintProviderCredential(apiKey: string): string {
return createHmac('sha256', getEncryptionKey())
.update(apiKey)
.update(apiKey) // codeql[js/insufficient-password-hash] -- This keyed HMAC is an identifier, not a password verifier.
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
.digest('hex')
.slice(0, 12);
}
Loading