Skip to content

[Docs] Clarify provider credential fingerprint security model - #1549

Merged
mrubens merged 3 commits into
developfrom
fix/codeql-credential-fingerprint-0xc8bltk72v80
Aug 23, 2026
Merged

[Docs] Clarify provider credential fingerprint security model#1549
mrubens merged 3 commits into
developfrom
fix/codeql-credential-fingerprint-0xc8bltk72v80

Conversation

@roomote-roomote

@roomote-roomote roomote-roomote Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

​Created by Roomote. View the task or mention @roomote-roomote for follow-up asks.

What changed

Documented the security model around the provider credential fingerprint helper. The helper still produces the same keyed HMAC-SHA-256 value truncated to 12 hexadecimal characters.

Why this change was made

CodeQL alert #108 models provider API keys as passwords and recommends a password KDF. These fingerprints are deterministic, non-secret identifiers used for grouping and deduplication, not password verifiers, so password-hashing semantics do not apply.

Impact

There is no runtime behavior change. The documentation makes the false-positive rationale durable without obscuring data flow or weakening CodeQL analysis.

@roomote-community

roomote-community Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

No new commits to review. See task

Reviewed f46685d

Comment thread packages/db/src/lib/provider-credential-fingerprint.ts Fixed
Comment thread packages/db/src/lib/provider-credential-fingerprint.ts Fixed
@roomote-roomote roomote-roomote Bot changed the title [Chore] Suppress false-positive provider fingerprint alert [Docs] Clarify provider credential fingerprint security model Aug 23, 2026
@mrubens
mrubens marked this pull request as ready for review August 23, 2026 12:48
@mrubens
mrubens merged commit 757b770 into develop Aug 23, 2026
16 checks passed
@mrubens
mrubens deleted the fix/codeql-credential-fingerprint-0xc8bltk72v80 branch August 23, 2026 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants