Skip to content

Stop sending admin emails on every HTTP 500 in production #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mihow merged 2 commits into from
Jul 23, 2026
Merged

Stop sending admin emails on every HTTP 500 in production #1356

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
585b1b0
fix: stop admin emails on every HTTP 500 in production
mihow Jun 29, 2026
8ccbc17
fix: make the admin-emails-on path an explicit branch
mihow Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions config/settings/production.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,22 @@
},
}

# Django's default mail_admins handler sends email synchronously, blocking a worker
# thread per HTTP 500; other (async/queued) handlers are recommended. Disabled by
# default and gated behind an env var; errors are already captured by Sentry.
ADMIN_ERROR_EMAILS = env.bool("DJANGO_ADMIN_ERROR_EMAILS", default=False)
if not ADMIN_ERROR_EMAILS:
LOGGING["loggers"]["django"] = {
"level": "INFO",
"handlers": ["console"],
"propagate": False,
}
Comment thread
mihow marked this conversation as resolved.
Comment thread
mihow marked this conversation as resolved.
else:
# Nothing to wire here: Django's DEFAULT_LOGGING attaches the mail_admins handler
# to the "django" logger before this module's LOGGING is applied. Explicit branch
# so the "on" path is visible here instead of hidden in Django's defaults. See #1356.
pass

# Sentry
# ------------------------------------------------------------------------------
SENTRY_DSN = env("SENTRY_DSN")
Expand Down
Loading