fix(nav2): reject non-finite NavigateToPose coordinates - #836
Closed
Bartok9 wants to merge 1 commit into
Closed
Conversation
Validate x/y/z/yaw with require_finite_float so agent tool calls cannot pass NaN/Inf/bool into Nav2 goals. Signed-off-by: Bartok9 <danielrpike9@gmail.com>
Member
|
In #872 as allow_inf_nan=False on the four NavigateToPoseToolInput fields, which is the pydantic equivalent of the finite check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject NaN/Inf/bool x/y/z/yaw on NavigateToPoseTool via require_finite_float.
Testing
Claim: bartok
Operator: bartok
Campaign: aerial-drone