Migrate CLN hold invoices to Boltz hold#2492
Open
vegita wants to merge 1 commit into
Open
Conversation
Author
|
CI note: the Python lint job passed. Both coordinator test jobs failed before compose/tests at the shared frontend artifact download step (dawidd6/action-download-artifact reports |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
holdinvoiceRPCs to Boltzhold(Invoice,List,Settle,Cancel)holdv0.3.3holdLinux amd64 release binaryFixes #2317
Verification
python -m py_compile api\\lightning\\cln.pydocker compose -f docker-tests.yml --env-file tests/compose.env config --quiethold_pb2.pyandhold_pb2_grpc.pyfrom the Boltz v0.3.3 proto in a temp venv and validated the expected request fields, RPC methods, and state enum valuesI could not run the full Docker integration suite locally because Docker Desktop's Linux engine is not running on this machine (
dockerDesktopLinuxEnginepipe is missing).