test: cover full per-offering config migration on issuer transfer - #859
Open
ogbemercyada-sketch wants to merge 1 commit into
Open
test: cover full per-offering config migration on issuer transfer#859ogbemercyada-sketch wants to merge 1 commit into
ogbemercyada-sketch wants to merge 1 commit into
Conversation
Add comprehensive config-migration test matrix for accept_issuer_transfer
verifying that InvestmentConstraints, ClaimDelaySecs, SnapshotConfig, and
LastSnapshotRef follow the offering under the new issuer identity.
Changes:
- Fix test_issuer_transfer_migrates_all_configs: correct set_concentration_limit
signature (add missing max_staleness_secs=&0u64 arg), add assert for rounding
mode defaulting to Truncation under old issuer, add descriptive failure messages
- Add config_migration_setup() helper to de-duplicate test boilerplate
- Add 10 new tests covering:
* Partial config (only 2/7 set): unset configs remain at defaults after transfer
* Transfer-then-set: new issuer can overwrite all configs post-transfer
* Old-issuer exclusion: old issuer cannot set investment constraints, claim
delay, or snapshot config after transfer (three separate boundary tests)
* Fresh-registration isolation: old issuer registering a new offering after
transfer starts with clean defaults, not contaminated by migrated-away keys
* Large snapshot ref boundary: u64 value 0xFFFF_FFFF_FFFF survives migration
* Both-zero investment constraints (min=0, max=0) migrate correctly
* Zero claim delay set explicitly still yields 0 under both issuers
* Multi-namespace isolation: ns_a transfer does not affect ns_b configs
- Apply cargo fmt --all to fix pre-existing formatting drift in lib.rs,
tax_bucket.rs, and test_tax_year.rs so CI fmt check passes
Closes RevoraOrg#844
|
@ogbemercyada-sketch Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add comprehensive config-migration test matrix for accept_issuer_transfer verifying that InvestmentConstraints, ClaimDelaySecs, SnapshotConfig, and LastSnapshotRef follow the offering under the new issuer identity.
Changes:
Closes #844