feat: wire scheduled reconciliation with dead-letter alarms - #900
Merged
thlpkee20-wq merged 2 commits intoAug 31, 2026
Merged
Conversation
Wire the scheduled RevenueReconciliationService cadence into the running app (index.ts) gated by a new 'reconciliation' worker-role capability, and expose reconciliation alarms/discrepancy metrics via a token-protected /metrics/reconciliation endpoint using the same globalMetrics collector. - Add PostgresReconciliationRunStore backed by reconciliation_run_summaries (parameterised INSERT ... ON CONFLICT DO NOTHING, keyed by (offering_id, period_id, started_at); getLastRun via latest started_at). - Add createReconciliationSchedulerRuntime interval wrapper with immediate first tick, overlap run-guard, and throw-isolation; interval configurable via RECONCILIATION_INTERVAL_MS (default 30m). - Export DEFAULT_RECONCILIATION_INTERVAL_MS / RECONCILIATION_INTERVAL_ENV and a pure resolveSchedulerInterval() helper. - Gate startup by roleConfig.reconciliation (batch/all); register scheduler stop on SIGTERM/SIGINT. - Document scheduled execution, env override, and run-summary persistence. Tests: 41/41 scheduler unit + runtime tests pass; no new tsc errors in touched files.
|
@aliyuHabibu Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire the scheduled RevenueReconciliationService cadence into the running app (index.ts) gated by a new 'reconciliation' worker-role capability, and expose reconciliation alarms/discrepancy metrics via a token-protected /metrics/reconciliation endpoint using the same globalMetrics collector.
Tests: 41/41 scheduler unit + runtime tests pass; no new tsc errors in touched files.
Close #861