feat: Ensure installation of stock APK during root installation#126
Open
feat: Ensure installation of stock APK during root installation#126
Conversation
Ushie
changed the title
oSumAtrIX
reviewed
Apr 5, 2026
oSumAtrIX
reviewed
Apr 5, 2026
oSumAtrIX
reviewed
Apr 5, 2026
oSumAtrIX
reviewed
Apr 5, 2026
4 tasks
oSumAtrIX
reviewed
Apr 9, 2026
oSumAtrIX
reviewed
Apr 9, 2026
oSumAtrIX
reviewed
Apr 9, 2026
oSumAtrIX
reviewed
Apr 9, 2026
oSumAtrIX
reviewed
Apr 9, 2026
oSumAtrIX
reviewed
Apr 9, 2026
oSumAtrIX
reviewed
Apr 14, 2026
| internal class PackageNameRequiredException internal constructor() : Exception("Package name is required") | ||
| internal class NoRootPermissionException internal constructor() : Exception("No root permission") | ||
| internal class NoRootPermissionException internal constructor() : | ||
| Exception("Root permission is not granted") |
Member
There was a problem hiding this comment.
Isnt no root permission simpler
oSumAtrIX
reviewed
Apr 14, 2026
| val stockApk: Apk, | ||
| ) : InstallerOptions(patchedApk) | ||
|
|
||
| class Apk(file: File, val packageName: String, val versionName: String) : Installer.Apk(file) No newline at end of file |
Member
There was a problem hiding this comment.
Any reason this class is inside the RootInstallerOptions.kt class? Class apk is inside the Installer class, so this class should be inside RootInstaller.kt
Member
Author
There was a problem hiding this comment.
You are right, but since the options were moved out of the Installer class, maybe class APK should move to InstallerOptions instead since thats where it's usage is
Member
There was a problem hiding this comment.
Would be breaking change, refactoring like this can come in another PR, for now put APK in RootInstaller for consistency
oSumAtrIX
reviewed
Apr 14, 2026
| ) | ||
| } | ||
|
|
||
| fun getInstalledVersionName(packageName: String): String = |
Member
There was a problem hiding this comment.
Why were these APIs added here instead of a utils class? Is it because it needs the shell command runner? In the case of a utils class a command runner can be passed to it for this purpose
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.