feat: Add mount, unmount and isMounted to RootInstaller#125
feat: Add mount, unmount and isMounted to RootInstaller#125
Conversation
| ) | ||
| } | ||
|
|
||
| suspend fun mount(packageName: String): RootInstallerResult { |
There was a problem hiding this comment.
Granular mount and unmount control should never be needed. Callsite should ever need to either install, or uninstall, which the current APIs already provide.
There was a problem hiding this comment.
I have seen a few users use the control to their advantage, most recent one I saw was where their mounted app was crashing, instead of repatching they unmounted, updated the unpatched app then remounted
This could be achieved by proxy by switching to magisk modules, users can simply disable or enable the module if they want
There was a problem hiding this comment.
instead of repatching they unmounted, updated the unpatched app then remounted
This is possible without unmounting. They can simply update the unpatched app. However, a desync in the installation is not something that is intended to be something that the user should take care of. It is an edge case that should be handled by the installer. E.g. it should detect that the app is updated/correct version installed and mount or similiar, so once again the correct solution is not to shift the responsibility to the user with granular control.
There was a problem hiding this comment.
This could be achieved by proxy by switching to magisk modules, users can simply disable or enable the module if they want
We intend to keep this method of installation as a legacy version, the magisk installation will only work on magisk so other root solutions would have to rely on the legacy/"agnostic" root installation
2 participants
No description provided.