Skip to content

Fix loot pagination counts with filters - #111

Merged
ianfhunter merged 1 commit into
mainfrom
codex/fix-inaccurate-results-count-with-filters
Jul 27, 2026
Merged

Fix loot pagination counts with filters#111
ianfhunter merged 1 commit into
mainfrom
codex/fix-inaccurate-results-count-with-filters

Conversation

@ianfhunter

Copy link
Copy Markdown
Collaborator

Motivation

  • Pagination copy in the Loot tab could report misleading totals when name/type/purchasable filters were active and did not handle the zero-results filtered state clearly.

Description

  • Add unfilteredResultCount and compute it when results are first built to preserve the original result total in assets/js/loot.js.
  • Introduce activeDisplayFilters() and resultCountLabel() helpers to produce filter-aware result labels (e.g. "X filtered items (from Y items)").
  • Update the pagination rendering to always show accurate filtered counts and to display an explicit zero-results message when filters remove all rows.

Testing

  • Static syntax check with node --check assets/js/loot.js completed successfully.
  • Repository diff/whitespace checks ran with no reported issues.

Codex Task

@cursor

cursor Bot commented Jul 27, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-07-27 13:43 UTC

@ianfhunter
ianfhunter merged commit 1706cbc into main Jul 27, 2026
1 check passed
@ianfhunter
ianfhunter deleted the codex/fix-inaccurate-results-count-with-filters branch July 27, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant