Fix mainnet snapshot mirror digest handling - #3028
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🛡️ AI Review — Skeptic (security review)VERDICT: SAFE VERY HIGH account-age/public-repo scrutiny, tempered by repository admin status and substantial merged contributions; no Gittensor association; branch snapshot-artifact-digest-prefix → main. The change replaces direct use of the upload action’s raw digest with the existing allowlisted current-run helper, which resolves exactly one non-expired artifact from the immutable current workflow run and validates the API-normalized SHA-256 digest. No AI-review trust-boundary files, dependency surfaces, runtime code, or credential permissions are changed. FindingsNo findings. ConclusionThe small, purpose-matched diff narrows artifact selection to the current run and introduces no security vulnerability or malicious behavior. 🔍 AI Review — Auditor (domain review)VERDICT: 👍 Gittensor association: UNKNOWN; newer but high-activity repository administrator, reviewed with external-contributor scrutiny. The workflow now resolves the uploaded snapshot through the existing current-run helper, which obtains and validates the API-normalized PR #2853 overlaps only in shared CI infrastructure and addresses an unrelated TypeScript SDK change; it is not duplicate work. FindingsNo findings. ConclusionThe change is minimal, consistent with the PR description, and correctly reuses the established artifact-selection boundary. No blocking domain issues found. |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
Summary
sha256:digest instead of passing the raw upload-action outputContext
The snapshot artifact upload succeeds, but the mirror publisher rejects the upload action’s unprefixed digest. That makes the trusted producer run fail, so the local artifact cache correctly refuses it and consumers fall back to GitHub.
Validation
.github/scripts/test-r2-artifact-mirror.pyrefresh-mainnet-snapshot.ymlandvalidate-sccache.ymlgit diff --check