Classify the two emission-gate AdminUtils calls in the proxy call groups - #3021
Open
philipmaymin wants to merge 1 commit into
Open
Classify the two emission-gate AdminUtils calls in the proxy call groups#3021philipmaymin wants to merge 1 commit into
philipmaymin wants to merge 1 commit into
Conversation
sudo_set_emission_bar_quantile and sudo_set_emission_gate_exponent are absent from the runtime proxy call inventory and from the SDK coverage list, so proxy_filters fails four tests and codegen.check --coverage reports both calls as having no status. Both are ensure_root global parameters, so they go in RootConfigCalls beside the sudo_set_tao_flow_* setters they were added alongside, and in RAW_ONLY["AdminUtils"] beside the other root-origin sudo_set_* entries. all_call_groups_cover_runtime_call_metadata is what stops a new extrinsic from silently landing in a permissive proxy group, and it cannot do that while it is already failing.
|
@philipmaymin is attempting to deploy a commit to the RaoFoundation Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
sudo_set_emission_bar_quantileandsudo_set_emission_gate_exponent(pallets/admin-utils/src/lib.rs:2021and:2042) are absent from the runtime proxy call inventory and from the SDK coverage list. Both gates are red onmain.Runtime.
cargo test -p node-subtensor-runtime proxy_filtersfails four tests:The first names the shortfall directly:
The other three are downstream of the same gap: they assert
allowed_calls(...) == all_runtime_calls() - denied, and unclassified calls break that identity.SDK.
runtime-checks.yml:504runscodegen.check --coverage, which reports the same two calls as having no status._generated/calls.pywas regenerated for spec 440 and does contain both, so the drift gate was satisfied; the classification step is what was missed, in both places.What this changes
Both extrinsics are
ensure_rootglobal emission-gate parameters, so they go inRootConfigCallsnext to thesudo_set_tao_flow_*setters they were added alongside, and inRAW_ONLY["AdminUtils"]next to the other root-originsudo_set_*entries.There is a second cost beyond the red CI.
all_call_groups_cover_runtime_call_metadatais the mechanism that stops a newly added extrinsic from silently landing in a permissive proxy group. It cannot do that job while it is already failing, because a new failure is indistinguishable from the existing one.Related Issue(s)
None filed.
Type of Change
Breaking Change
None. Both calls are root-origin only, so no proxy type gains reachable authority it did not already have through sudo.
Checklist
./scripts/fix_rust.shto fix formatting and clippy issuesNo test added: the completeness test already existed and was failing. This makes it pass.
I could not run
codegen.check --coveragelocally (bittensor_coreis not built in my environment), so the SDK half of this rests on your CI. The runtime half I ran.Additional Notes
If the grouping choice is wrong I will move them.
RootConfigCallsmatched both the origin (ensure_root) and the neighbours these two arrived with, but you know the intent behind those groups better than I do.