Skip to content

Allow the Staking proxy to call claim_root #3015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yeuyeuh wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −3
Open

Allow the Staking proxy to call claim_root #3015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/guides/proxies.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ Prefer the narrowest type that covers the job:
**SmallTransfer** is the same but caps each transfer below 0.5 TAO
(0.5 alpha for stake transfers).
* **Staking** — stake add / remove / move / swap / unstake-all and their
limit variants, plus [`set_root_claim_type`](/code/pallets/subtensor/src/macros/dispatches.rs#L1937-L1951). Its allowlist does *not*
limit variants, plus [`set_root_claim_type`](/code/pallets/subtensor/src/macros/dispatches.rs#L1937-L1951) and [`claim_root`](/code/pallets/subtensor/src/macros/dispatches.rs#L1910-L1926). Its allowlist does *not*
include [`Utility.batch_all`](/code/pallets/utility/src/lib.rs#L314-L362), so batched staking through a Staking proxy
fails with `CallFiltered` — use NonTransfer for batched staking.
* **Registration** — neuron registration ([`burned_register`](/code/pallets/subtensor/src/macros/dispatches.rs#L826-L832), [`register`](/code/pallets/subtensor/src/macros/dispatches.rs#L804-L814),
Expand Down
9 changes: 7 additions & 2 deletions runtime/src/proxy_filters/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,12 @@ type AdminAll = (SubnetManagementCalls, RootConfigCalls, OwnerKeyCalls);
/// `Transfer`: liquid value movement.
type TransferAllowed = (BalanceTransferCalls, StakeTransferCalls);

/// `Staking`: stake position management plus root-claim mode selection.
type StakingAllowed = (StakeManagementCalls, RootClaimTypeCalls);
/// `Staking`: stake position management and root-claim mode selection, plus
/// claiming the root dividends those positions accrue. Granting a staking
/// proxy is an explicit signal of trust that the proxy manages the coldkey's
/// stake, and `claim_root` can only restake the payout on root for that same
/// coldkey.
type StakingAllowed = (StakeManagementCalls, RootClaimTypeCalls, RootClaimCalls);

/// `Registration`: acquire a slot (POW or by burn).
type RegistrationAllowed = (PowRegistrationCalls, BurnedRegistrationCalls);
Expand Down Expand Up @@ -475,6 +479,7 @@ mod tests {
"SubtensorModule::add_collateral",
"SubtensorModule::add_stake",
"SubtensorModule::add_stake_limit",
"SubtensorModule::claim_root",
"SubtensorModule::remove_stake",
"SubtensorModule::remove_stake_limit",
"SubtensorModule::remove_stake_full_limit",
Expand Down