Repository navigation
Updated readme - #28
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project's publication reference from a preprint to the final published version and modernizes the installation instructions. The DOI has been updated from the SSRN preprint (10.2139/ssrn.5276153) to the final Building and Environment journal publication (10.1016/j.buildenv.2025.113640).
- Updated citation and DOI badge to reference the final published journal article
- Simplified installation instructions to use Python venv instead of conda
- Updated project structure documentation to reflect actual directories (
buildandunittestsinstead ofArchive)
Reviewed Changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Updated DOI badge and citation to published journal article, changed installation from conda to venv, and corrected project structure documentation |
| .gitignore | Added /venv to ignore list to support the updated venv-based installation workflow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| To cite physXAI, please use the following paper: | ||
|
|
||
| > Henkel, Patrick and Roß, Simon and Rätz, Martin and Müller, Dirk, Monotonic Physics-Constrained Neural Networks for Model Predictive Control of Building Energy Systems. Available at SSRN: https://ssrn.com/abstract=5276153 or http://dx.doi.org/10.2139/ssrn.5276153 | ||
| > Henkel, Patrick and Roß, Simon and Rätz, Martin and Müller, Dirk, Monotonic physics-constrained neural networks for model predictive control of building energy systems. 2025.Available at Building and Environment: https://doi.org/10.1016/j.buildenv.2025.113640 |
There was a problem hiding this comment.
Missing space after '2025.' - should be '2025. Available' instead of '2025.Available'.
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
|
@PatrickHenkel1 I've opened a new pull request, #29, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: PatrickHenkel1 <77100318+PatrickHenkel1@users.noreply.github.com>
Fix missing space in README citation
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| To cite physXAI, please use the following paper: | ||
|
|
||
| > Henkel, Patrick and Roß, Simon and Rätz, Martin and Müller, Dirk, Monotonic Physics-Constrained Neural Networks for Model Predictive Control of Building Energy Systems. Available at SSRN: https://ssrn.com/abstract=5276153 or http://dx.doi.org/10.2139/ssrn.5276153 | ||
| > Henkel, Patrick and Roß, Simon and Rätz, Martin and Müller, Dirk, Monotonic physics-constrained neural networks for model predictive control of building energy systems. 2025. Available at Building and Environment: https://doi.org/10.1016/j.buildenv.2025.113640 |
There was a problem hiding this comment.
The citation format is incomplete. It should include the journal name, volume, and page numbers. A more complete format would be: 'Henkel, Patrick and Roß, Simon and Rätz, Martin and Müller, Dirk, Monotonic physics-constrained neural networks for model predictive control of building energy systems. Building and Environment, 2025, 268, 113640. https://doi.org/10.1016/j.buildenv.2025.113640'
| > Henkel, Patrick and Roß, Simon and Rätz, Martin and Müller, Dirk, Monotonic physics-constrained neural networks for model predictive control of building energy systems. 2025. Available at Building and Environment: https://doi.org/10.1016/j.buildenv.2025.113640 | |
| > Henkel, Patrick and Roß, Simon and Rätz, Martin and Müller, Dirk, Monotonic physics-constrained neural networks for model predictive control of building energy systems. Building and Environment, 2025, 268, 113640. https://doi.org/10.1016/j.buildenv.2025.113640 |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.